Skip to content

chore: remove smart account upgrade splash page and related preferences#26116

Open
jpuri wants to merge 3 commits intomainfrom
cleanup_upgrade_acc_opt_in_preference
Open

chore: remove smart account upgrade splash page and related preferences#26116
jpuri wants to merge 3 commits intomainfrom
cleanup_upgrade_acc_opt_in_preference

Conversation

@jpuri
Copy link
Contributor

@jpuri jpuri commented Feb 16, 2026 •
edited by cursor bot
Loading

Description

Remove smart account upgrade splash page and related code and preferences.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/7007

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Moderate risk because it changes confirmation/navigation flow by removing a previously-rendered overlay and route; regressions would surface as missing/incorrect upgrade prompting or navigation errors if any callers still reference removed routes/preferences.

Overview
Removes the smart account upgrade splash/opt-in UX from confirmations and navigation: the Splash overlay and SmartAccountUpdateModal route are deleted, and Confirm no longer renders the splash component.

Cleans up the related settings/preferences surface by removing the Advanced Settings “Use smart account” toggle, the smartAccountOptIn selector/analytics event/test IDs, and associated i18n strings across locales.

Written by Cursor Bugbot for commit b29b773. This will update automatically on new commits. Configure here.

@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Feb 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jpuri jpuri marked this pull request as ready for review February 16, 2026 13:20
@jpuri jpuri requested review from a team as code owners February 16, 2026 13:20
@jpuri jpuri enabled auto-merge February 16, 2026 13:21
cursor[bot]
cursor bot reviewed Feb 16, 2026
View reviewed changes
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@jpuri jpuri marked this pull request as draft February 16, 2026 14:42
auto-merge was automatically disabled February 16, 2026 14:42

Pull request was converted to draft

@jpuri jpuri marked this pull request as ready for review February 16, 2026 15:19
@github-actions github-actions bot added size-L and removed size-XL labels Feb 16, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 16, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR removes the Smart Account Opt-In feature, which was part of the EIP-7702 smart account upgrade flow. The changes include:

  1. Deleted Components: SmartAccountUpdateModal, SmartAccountUpdateSplash, SmartAccountUpdateContent, and Splash components
  2. Navigation Changes: Removed SMART_ACCOUNT_OPT_IN route from Routes.ts and the ModalSmartAccountOptIn navigator from App.tsx
  3. Selector/Event Removal: Removed selectSmartAccountOptIn selector and SMART_ACCOUNT_OPT_IN analytics event
  4. Confirmation Flow Impact: Removed the <Splash /> component from the confirmation flow in confirm-component.tsx

The changes are primarily deletions of a feature. The confirmation flow is still intact, just without the smart account opt-in splash screen. Since this modifies the confirmation component (confirm-component.tsx) by removing the Splash component, we should run SmokeConfirmations to ensure the confirmation flow still works correctly.

No E2E tests were found specifically for the smart account opt-in feature (searched for smart.*account, 7702, etc.), so the existing confirmation tests should be sufficient to verify the confirmation flow still works after these deletions.

The changes don't affect other areas like accounts, identity, network, trade, or wallet platform features - they are isolated to the confirmation flow's smart account upgrade splash screen.

Performance Test Selection:
This PR removes UI components (SmartAccountUpdateModal, SmartAccountUpdateSplash, Splash) from the confirmation flow. The changes are deletions that simplify the confirmation flow by removing the smart account opt-in splash screen. This should not negatively impact performance - if anything, it may slightly improve confirmation flow performance by removing an extra component. No performance tests are needed as there are no new components, no changes to data loading, no changes to list rendering, and no changes to app startup or critical user flows that would warrant performance testing.

View GitHub Actions results

@jpuri jpuri enabled auto-merge February 16, 2026 15:21
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 16, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed size-L team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jpuri